Address AX review feedback

- Fix status hint: clarify step() vs setBreakpoint+continue for pausing
- Add flag string to getRegisters: "NV-BDIZC" format (uppercase=set)
- Add listBreakpoints tool with local breakpoint tracking
- Track breakpoints in client for listing support

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Simen Svale 2025-12-30 01:53:16 +01:00
parent 32eb8f3c17
commit 84b10689d0
2 changed files with 79 additions and 3 deletions

View file

@ -94,8 +94,8 @@ Related tools: connect, disconnect`,
}), }),
hint: state.connected hint: state.connected
? state.running ? state.running
? "VICE is running. Use step() to pause execution." ? "VICE is running. Use setBreakpoint() + continue() to pause at a specific point, or step() to execute one instruction."
: "VICE is paused. Use continue() to resume." : "VICE is paused. Use continue() to resume or step() to execute one instruction."
: "Not connected. Use connect() to establish connection to VICE.", : "Not connected. Use connect() to establish connection to VICE.",
}); });
} }
@ -383,6 +383,17 @@ Related tools: setRegister, step, continue, status`,
zero: !!(flags & 0x02), zero: !!(flags & 0x02),
carry: !!(flags & 0x01), carry: !!(flags & 0x01),
raw: flags, raw: flags,
// Compact string representation: NV-BDIZC (uppercase = set)
string: [
flags & 0x80 ? "N" : "n",
flags & 0x40 ? "V" : "v",
"-",
flags & 0x10 ? "B" : "b",
flags & 0x08 ? "D" : "d",
flags & 0x04 ? "I" : "i",
flags & 0x02 ? "Z" : "z",
flags & 0x01 ? "C" : "c",
].join(""),
}; };
return formatResponse({ return formatResponse({
@ -597,6 +608,45 @@ Related tools: setBreakpoint, listBreakpoints`,
} }
); );
// Tool: listBreakpoints - List all breakpoints
server.registerTool(
"listBreakpoints",
{
description: `List all active breakpoints.
Shows breakpoint IDs, addresses, and status for all breakpoints set in this session.
Note: This tracks breakpoints set through this MCP session. Breakpoints set through VICE's built-in monitor may not appear.
Related tools: setBreakpoint, deleteBreakpoint`,
},
async () => {
const breakpoints = client.listBreakpoints();
if (breakpoints.length === 0) {
return formatResponse({
count: 0,
breakpoints: [],
hint: "No breakpoints set. Use setBreakpoint() to add one.",
});
}
return formatResponse({
count: breakpoints.length,
breakpoints: breakpoints.map((bp) => ({
id: bp.id,
address: {
value: bp.address,
hex: `$${bp.address.toString(16).padStart(4, "0")}`,
},
enabled: bp.enabled,
temporary: bp.temporary,
})),
hint: `${breakpoints.length} breakpoint(s) active. Use deleteBreakpoint(id) to remove.`,
});
}
);
async function main() { async function main() {
const transport = new StdioServerTransport(); const transport = new StdioServerTransport();
await server.connect(transport); await server.connect(transport);

View file

@ -18,6 +18,13 @@ export interface ViceError {
suggestion?: string; suggestion?: string;
} }
export interface BreakpointInfo {
id: number;
address: number;
enabled: boolean;
temporary: boolean;
}
export class ViceClient { export class ViceClient {
private socket: Socket | null = null; private socket: Socket | null = null;
private requestId = 0; private requestId = 0;
@ -35,6 +42,8 @@ export class ViceClient {
port: 0, port: 0,
running: true, running: true,
}; };
// Track breakpoints locally (VICE doesn't have a reliable list command in all versions)
private breakpoints = new Map<number, BreakpointInfo>();
// Event handlers for async events (breakpoints, etc.) // Event handlers for async events (breakpoints, etc.)
public onStopped?: (response: ViceResponse) => void; public onStopped?: (response: ViceResponse) => void;
@ -415,13 +424,30 @@ export class ViceClient {
body[7] = temporary ? 1 : 0; body[7] = temporary ? 1 : 0;
const response = await this.sendCommand(Command.CheckpointSet, body); const response = await this.sendCommand(Command.CheckpointSet, body);
return response.body.readUInt32LE(0); const id = response.body.readUInt32LE(0);
// Track locally
this.breakpoints.set(id, {
id,
address,
enabled,
temporary,
});
return id;
} }
async deleteBreakpoint(checkpointId: number): Promise<void> { async deleteBreakpoint(checkpointId: number): Promise<void> {
const body = Buffer.alloc(4); const body = Buffer.alloc(4);
body.writeUInt32LE(checkpointId, 0); body.writeUInt32LE(checkpointId, 0);
await this.sendCommand(Command.CheckpointDelete, body); await this.sendCommand(Command.CheckpointDelete, body);
// Remove from local tracking
this.breakpoints.delete(checkpointId);
}
listBreakpoints(): BreakpointInfo[] {
return Array.from(this.breakpoints.values());
} }
} }