package commands import ( "strings" "testing" "c65gm/internal/compiler" "c65gm/internal/preproc" ) func TestOrCommand_WillHandle(t *testing.T) { cmd := &OrCommand{} tests := []struct { name string line string want bool }{ {"old syntax WITH/GIVING", "OR a WITH b GIVING c", true}, {"old syntax WITH/arrow", "OR a WITH b -> c", true}, {"new syntax", "result = x | y", true}, {"not OR", "ADD a TO b GIVING c", false}, {"wrong param count", "OR a b c", false}, {"empty", "", false}, {"new syntax wrong op", "result = x + y", false}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { line := preproc.Line{Text: tt.line, Kind: preproc.Source} got := cmd.WillHandle(line) if got != tt.want { t.Errorf("WillHandle() = %v, want %v", got, tt.want) } }) } } func TestOrCommand_OldSyntax(t *testing.T) { tests := []struct { name string line string setupVars func(*compiler.SymbolTable) wantAsm []string wantErr bool }{ { name: "byte OR byte -> byte (variables)", line: "OR a WITH b GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddVar("b", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda a", "\tora b", "\tsta result", }, }, { name: "byte OR byte -> word", line: "OR a WITH b GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddVar("b", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda a", "\tora b", "\tsta result", "\tlda #0", "\tora #0", "\tsta result+1", }, }, { name: "word OR word -> word", line: "OR x WITH y GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("x", "", compiler.KindWord, 0x1234) st.AddVar("y", "", compiler.KindWord, 0x0F0F) st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda x", "\tora y", "\tsta result", "\tlda x+1", "\tora y+1", "\tsta result+1", }, }, { name: "byte OR literal -> byte", line: "OR a WITH $0F GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda a", "\tora #$0f", "\tsta result", }, }, { name: "literal OR byte -> byte", line: "OR 15 WITH b GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("b", "", compiler.KindByte, 0xF0) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda #$0f", "\tora b", "\tsta result", }, }, { name: "constant folding: 15 OR 240 -> byte", line: "OR 15 WITH 240 GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda #$ff", "\tsta result", }, }, { name: "constant folding: $00F0 OR $0F00 -> word", line: "OR $00F0 WITH $0F00 GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda #$f0", "\tsta result", "\tlda #$0f", "\tsta result+1", }, }, { name: "arrow syntax", line: "OR a WITH b -> result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0) st.AddVar("b", "", compiler.KindByte, 0) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda a", "\tora b", "\tsta result", }, }, { name: "word OR byte -> byte", line: "OR wval WITH bval GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("wval", "", compiler.KindWord, 0x1234) st.AddVar("bval", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda wval", "\tora bval", "\tsta result", }, }, { name: "word OR byte -> word", line: "OR wval WITH bval GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("wval", "", compiler.KindWord, 0x1234) st.AddVar("bval", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda wval", "\tora bval", "\tsta result", "\tlda wval+1", "\tora #0", "\tsta result+1", }, }, { name: "error: unknown destination variable", line: "OR a WITH b GIVING unknown", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0) st.AddVar("b", "", compiler.KindByte, 0) }, wantErr: true, }, { name: "error: wrong separator", line: "OR a TO b GIVING result", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0) st.AddVar("b", "", compiler.KindByte, 0) st.AddVar("result", "", compiler.KindByte, 0) }, wantErr: true, }, { name: "error: cannot assign to constant", line: "OR a WITH b GIVING MAXVAL", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0) st.AddVar("b", "", compiler.KindByte, 0) st.AddConst("MAXVAL", "", compiler.KindByte, 255) }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { ctx := compiler.NewCompilerContext(&preproc.Pragma{}) tt.setupVars(ctx.SymbolTable) cmd := &OrCommand{} line := preproc.Line{Text: tt.line, Kind: preproc.Source} err := cmd.Interpret(line, ctx) if tt.wantErr { if err == nil { t.Error("expected error, got nil") } return } if err != nil { t.Fatalf("Interpret() error = %v", err) } asm, err := cmd.Generate(ctx) if err != nil { t.Fatalf("Generate() error = %v", err) } if !equalAsmOr(asm, tt.wantAsm) { t.Errorf("Generate() mismatch\ngot:\n%s\nwant:\n%s", strings.Join(asm, "\n"), strings.Join(tt.wantAsm, "\n")) } }) } } func TestOrCommand_NewSyntax(t *testing.T) { tests := []struct { name string line string setupVars func(*compiler.SymbolTable) wantAsm []string wantErr bool }{ { name: "byte | byte -> byte", line: "result = a | b", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddVar("b", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda a", "\tora b", "\tsta result", }, }, { name: "byte | byte -> word", line: "result = a | b", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddVar("b", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda a", "\tora b", "\tsta result", "\tlda #0", "\tora #0", "\tsta result+1", }, }, { name: "word | word -> word", line: "result = x | y", setupVars: func(st *compiler.SymbolTable) { st.AddVar("x", "", compiler.KindWord, 0x1234) st.AddVar("y", "", compiler.KindWord, 0x0F0F) st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda x", "\tora y", "\tsta result", "\tlda x+1", "\tora y+1", "\tsta result+1", }, }, { name: "variable | literal", line: "result = a | $0F", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda a", "\tora #$0f", "\tsta result", }, }, { name: "constant folding", line: "result = 15 | 240", setupVars: func(st *compiler.SymbolTable) { st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda #$ff", "\tsta result", }, }, { name: "constant folding word", line: "result = $00F0 | $0F00", setupVars: func(st *compiler.SymbolTable) { st.AddVar("result", "", compiler.KindWord, 0) }, wantAsm: []string{ "\tlda #$f0", "\tsta result", "\tlda #$0f", "\tsta result+1", }, }, { name: "using constant in expression", line: "result = a | BITS", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0xF0) st.AddConst("BITS", "", compiler.KindByte, 0x0F) st.AddVar("result", "", compiler.KindByte, 0) }, wantAsm: []string{ "\tlda a", "\tora #$0f", "\tsta result", }, }, { name: "error: unknown destination", line: "unknown = a | b", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0) st.AddVar("b", "", compiler.KindByte, 0) }, wantErr: true, }, { name: "error: wrong operator", line: "result = a + b", setupVars: func(st *compiler.SymbolTable) { st.AddVar("a", "", compiler.KindByte, 0) st.AddVar("b", "", compiler.KindByte, 0) st.AddVar("result", "", compiler.KindByte, 0) }, wantErr: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { ctx := compiler.NewCompilerContext(&preproc.Pragma{}) tt.setupVars(ctx.SymbolTable) cmd := &OrCommand{} line := preproc.Line{Text: tt.line, Kind: preproc.Source} err := cmd.Interpret(line, ctx) if tt.wantErr { if err == nil { t.Error("expected error, got nil") } return } if err != nil { t.Fatalf("Interpret() error = %v", err) } asm, err := cmd.Generate(ctx) if err != nil { t.Fatalf("Generate() error = %v", err) } if !equalAsmOr(asm, tt.wantAsm) { t.Errorf("Generate() mismatch\ngot:\n%s\nwant:\n%s", strings.Join(asm, "\n"), strings.Join(tt.wantAsm, "\n")) } }) } } // equalAsmOr compares two assembly slices for equality func equalAsmOr(a, b []string) bool { if len(a) != len(b) { return false } for i := range a { if a[i] != b[i] { return false } } return true }